Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric block_sim_errors always output zero #245

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dvush
Copy link
Contributor

@dvush dvush commented Nov 12, 2024

📝 Summary

This change removes useless label from block sim error. This makes metrics always output 0 for this metric (before it was outputting nothing).

💡 Motivation and Context

This metric was not in metrics endpoint output so this lead to the following scenario:

  • metric was "null" before error
  • error happened once and now metric is showing "1"
  • alerts based on grafana functions such as "increase" are not triggered because it there are no increase if it was null before it became 1. This is hard to fix on the level of grafana since all solutions are alerting too much or to little.

So we force the metric to always be 0 in the output and it should make alerting on 0 -> 1 correct.

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copy link

Benchmark results for 9ea1a34

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/9ea1a34-6bb48bf/report/index.html

Date (UTC) 2024-11-12T11:55:53+00:00
Commit 9ea1a34dd73b5ca3eaa1c59ca0389c60a23ba0da
Base SHA 6bb48bf637e4b159687f53b49427f833f21970c1

Significant changes

Benchmark Mean Status
MEV-Boost SubmitBlock serialization/JSON encoding 52.54% Performance has degraded.

@dvush dvush merged commit 0ced7b0 into develop Nov 13, 2024
5 checks passed
@dvush dvush deleted the metric_block_sim_errors_fix branch November 13, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants