metric block_sim_errors always output zero #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This change removes useless label from block sim error. This makes metrics always output 0 for this metric (before it was outputting nothing).
💡 Motivation and Context
This metric was not in metrics endpoint output so this lead to the following scenario:
So we force the metric to always be 0 in the output and it should make alerting on 0 -> 1 correct.
✅ I have completed the following steps:
make lint
make test